Update grpc #1937
Merged
Update grpc #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changelog includes a lot of bugfixes most of which are about stuff we don't currently use. There is also mention of some proto codec optimization that shows 2-5% improvement.
….7.0 This also fixes #1928 among a lot of other bugfixes including more panics
Codecov Report
@@ Coverage Diff @@
## master #1937 +/- ##
==========================================
- Coverage 71.26% 71.22% -0.04%
==========================================
Files 183 183
Lines 14336 14336
==========================================
- Hits 10216 10211 -5
- Misses 3480 3485 +5
Partials 640 640
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
imiric
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates both the main grpc library - google.golang.org/grpc as well as the reflect protobuf one github.com/jhump/protoreflect and their dependencies.
Both are mostly a lot of bugfixes where most are unlikely to have anything to do with k6. The main gRPC library has a lot of changes(mostly fixes) concerning envoy related xDS and lrs, both of which I am not familiar with.
Probably the biggest noticeable change is from the protoreflect which fixes #1928.
Rerunning test from #1846 didn't show any meaningful change IMO